Avoid issues caused by clobbering of global setTimeout#1518
Merged
Conversation
Member
|
Merged, thank you, I like this approach better. |
Contributor
Author
|
No worries, thanks for merging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved version of PR #1402. Uses unqualified
setTimeoutas closure argument to avoid this vs global vs window issues.The rest of this description is lifted from original PR.
Ensuring global setTimeout reference is captured in require.js so that clobbering setTimeout does not break everything.
This is useful/necessary when using RequireJS with a unit test framework that simulates setTimeout (for example sinon.js). Since RequireJS relies on the default behavior of setTimeout and is a library which ideally should function the same way even when other frameworks are involved, it seems worthwhile to close over the default setTimeout function.
I've also added a unit test file to capture this-- please let me know if that can be improved.