Timeout errors should reject promises, provide error type info#41
Merged
Conversation
This was referenced Nov 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39 and #40:
Timeout errors were calling
requirejs.onErrordirectly, instead of rejecting the promise for the modules that timed out. This lead to inconsistent and incorrect error reporting.Adds
requireTypeto the Error objects for certain error cases to indicate the type of error. The type strings are taken from requirejs. alameda does not have the same error cases as requirejs, so only some of the error types from requirejs apply to alameda.