Merged
Conversation
|
Hi, thank you for your work here! thank you and best regards |
Contributor
Author
|
The status of my PR? As far as I'm aware it's fully working, and I'm waiting on a maintainer to review it |
caspervk
added a commit
to magenta-aps/httpx-ntlm
that referenced
this pull request
Jan 17, 2022
Based on this[1] pull request by J. Hill-Daniel (clubby789) in the requests-ntlm sister library. [1] requests#126
caspervk
added a commit
to magenta-aps/httpx-ntlm
that referenced
this pull request
Jan 17, 2022
Based on this[1] pull request by J. Hill-Daniel (clubby789) in the requests-ntlm sister library. [1] requests#126
|
Ahoi! Can we get an update on this? Otherwise I'd dive into pyspnego now. |
9 tasks
Closed
The ntlm_auth library is deprecated in favour of pyspnego. This commit migrates to this library, patching some methods to ensure dependent code will continue to work.
PySPNEGO handles the parsing of the domain component of the username
PySPNEGO allows usage of an NTLM hash in place of a password, so test that this is functioning properly.
nitzmahone
approved these changes
Feb 6, 2023
Contributor
|
Thanks for the PR @clubby789, I've slightly modified it to support channel binding tokens and not use the internals for the wrapping/unwrapping code. |
|
🎉 thanks @clubby789 and @jborean93 |
This was referenced Feb 6, 2023
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ntlm_auth library is deprecated in favour of pyspnego. This commit
migrates to this library, patching some methods to ensure dependent code
will continue to work.