Skip to content

HTTP Archive 1.2 support#1501

Merged
simov merged 6 commits into
request:masterfrom
ahmadnassri:master
Mar 24, 2015
Merged

HTTP Archive 1.2 support#1501
simov merged 6 commits into
request:masterfrom
ahmadnassri:master

Conversation

@ahmadnassri

Copy link
Copy Markdown

passing a HAR Request 1.2 in options.har will construct and set matching options values for use in the request.

this makes the library particularly useful when dealing with debug / performance data from many tools and proxies, especially to repeat requests from the browser's network panel.

@simov

simov commented Mar 22, 2015

Copy link
Copy Markdown
Member

Thanks @ahmadnassri ! Without being very familiar with HAR (or at all), I can say that your code looks great. 👍 from me for merging this PR.

The next request release is scheduled for the upcoming week, so in the meantime I'll review your code again more thoroughly, just to familiarize myself with HAR.

Comment thread lib/har.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, should be header

@nylen

nylen commented Mar 23, 2015

Copy link
Copy Markdown
Member

Thanks @ahmadnassri ! Without being very familiar with HAR (or at all), I can say that your code looks great. 👍 from me for merging this PR.

Same here, thank you for contributing :)

@simov I left some notes but I probably won't have time to do a more detailed code review.

@ahmadnassri

Copy link
Copy Markdown
Author

thanks for the notes @nylen, new commit coming right up.

@ahmadnassri

Copy link
Copy Markdown
Author

@simov you've inspired me to create this up-to-date collection of resources for HTTP Archive :)

@simov

simov commented Mar 24, 2015

Copy link
Copy Markdown
Member

That's a really comprehensive list @ahmadnassri 👍 I'll merge your PR shortly, in case anyone else have something to add. btw you have one more broken anchor where you link back to the HAR section from the options.

simov added a commit that referenced this pull request Mar 24, 2015
@simov simov merged commit ddab5e8 into request:master Mar 24, 2015
@ahmadnassri

Copy link
Copy Markdown
Author

I've added Request to the list of HAR Resources

cheers.

sabaoongfx pushed a commit to sabaoongfx/request-modern that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants