Skip to content

Support NPM packages which have links represented as arrays of strings#321

Merged
cbrewster merged 1 commit intomainfrom
12-19-Support_NPM_packages_which_have_links_represented_as_arrays_of_strings
Dec 19, 2024
Merged

Support NPM packages which have links represented as arrays of strings#321
cbrewster merged 1 commit intomainfrom
12-19-Support_NPM_packages_which_have_links_represented_as_arrays_of_strings

Conversation

@cbrewster
Copy link
Member

Why

Some packages appear to have their links represented as an array instead of a string. Let's support links in that format so upm search isn't broken.

What changed

  • Combine all the "link"-like structs into packageLink
  • packageLink supports 3 formats: "<link>", {"url": "<link>"}, or ["<link">]

Test plan

  • upm search -l nodejs mkdirp works again

@cbrewster cbrewster requested a review from a team as a code owner December 19, 2024 15:45
@cbrewster
Copy link
Member Author

cbrewster commented Dec 19, 2024

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@cbrewster cbrewster requested review from ryantm and vlinkz and removed request for a team December 19, 2024 15:45
@cbrewster cbrewster force-pushed the 12-19-Support_NPM_packages_which_have_links_represented_as_arrays_of_strings branch from 925109e to c44da40 Compare December 19, 2024 15:50
@cbrewster cbrewster added the bug Something isn't working label Dec 19, 2024
@cbrewster cbrewster enabled auto-merge (squash) December 19, 2024 15:51
@cbrewster cbrewster force-pushed the 12-19-Support_NPM_packages_which_have_links_represented_as_arrays_of_strings branch from c44da40 to de0f43c Compare December 19, 2024 16:17
@cbrewster cbrewster merged commit 0f86a14 into main Dec 19, 2024
@cbrewster cbrewster deleted the 12-19-Support_NPM_packages_which_have_links_represented_as_arrays_of_strings branch December 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants