The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
bugs	Ready	Preview, Comment	Apr 8, 2026 9:14am
remotion	Ready	Preview, Comment	Apr 8, 2026 9:14am

Reviewed PR #7022. The PR was already merged, so posted a comment with two non-blocking observations: (1) the canvas width/height guard in video-iterator-manager.ts is a subtle but critical coupling to the caching feature and deserves a code comment, and (2) the video-frame-cache.ts map grows without bound, which is fine while _experimental but should be addressed before graduation.

  ^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Big Pickle (free) ｜ 𝕏}

Post-merge review

Clean implementation. The effect ordering is correct — useLayoutEffect for draw/cache runs synchronously before paint, ahead of the useEffect that creates the MediaPlayer. The canvas context attributes ({alpha: true, desynchronized: true}) match between the cached-frame draw and the MediaPlayer constructor, so getContext won't return null due to attribute mismatch.

Two observations:

1. video-iterator-manager.ts — the width/height guard is load-bearing. Setting canvas.width (even to the same value) clears the canvas bitmap, which would wipe the cached frame drawn by useLayoutEffect before the first real frame arrives. This guard is the reason the cached frame survives until the MediaPlayer draws the real one. Worth adding a brief comment explaining why it exists — without it, the connection to the caching feature is non-obvious and someone could innocently revert to the simpler unconditional assignment.

2. video-frame-cache.ts — unbounded cache. The Map<string, OffscreenCanvas> grows without bound; each unique src holds a bitmap in memory indefinitely. For the current sliced-video use case (single source, many slices) this is fine, but if users adopt it for compositions with many distinct sources it could leak. Not a concern while _experimental, but worth keeping in mind for graduation — a simple LRU cap or WeakRef-based eviction would address it.

  ^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Big Pickle (free) ｜ 𝕏}