remotion.dev/convert: Fall back to in-memory target if Web FS is not available#7015
Merged
JonnyBurger merged 1 commit intomainfrom Apr 7, 2026
Merged
remotion.dev/convert: Fall back to in-memory target if Web FS is not available#7015JonnyBurger merged 1 commit intomainfrom
JonnyBurger merged 1 commit intomainfrom
Conversation
Contributor
|
Reviewed PR #7015 — approved with no issues. The detection change from property existence check to actual Task list (3/3 completed)
|
Contributor
Contributor
There was a problem hiding this comment.
Reviewed — no issues found.
Big Pickle (free) ｜ 𝕏
@remotion/webcodecs: Fix Web FS API detection in SafariProbe createWritable() before using OPFS; use a growing Uint8 buffer and return a File for download/use-as-input when the probe fails (e.g. Safari). Made-with: Cursor
653848a to
728d70c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canUseWebFsWritercheck across@remotion/webcodecs,@remotion/web-renderer, and@remotion/template-recorderto actually try callingfileHandle.createWritable()instead of just checking!== undefined. Safari partially supports OPFS butcreateWritable()is not functional, causing the old check to incorrectly returntrue.@remotion/convertso conversions work in Safari and other browsers that lackcreateWritable()support.Closes #7003
Test plan
createWritableexists on the prototype but throws when calledMade with Cursor