@remotion/studio-server: Remove duplicated codemod formatting logic#6999
Merged
JonnyBurger merged 1 commit intomainfrom Apr 5, 2026
Merged
@remotion/studio-server: Remove duplicated codemod formatting logic#6999JonnyBurger merged 1 commit intomainfrom
@remotion/studio-server: Remove duplicated codemod formatting logic#6999JonnyBurger merged 1 commit intomainfrom
Conversation
Co-authored-by: Jonny Burger <hi@jonny.io>
Contributor
|
Reviewed PR #6999. The removed inline Prettier formatting logic in Task list (4/4 completed)
|
Contributor
There was a problem hiding this comment.
Reviewed — no issues found.
Big Pickle (free) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/studio-server/src/codemods/duplicate-jsx-node.tsformatFileContent()helper already used bydelete-jsx-node.tsWhy
Issue #6993 points out duplicated boilerplate between codemods. This PR makes a focused cleanup of one concrete duplication hotspot in
duplicate-jsx-node.ts.Testing
bun test packages/studio-server/src/test/delete-jsx-node.test.ts packages/studio-server/src/test/duplicate-jsx-node.test.tsbun/bunxbinaries were not available on PATH, so tests could not be executed here.Tradeoffs