@remotion/player: Fix typo - rename persistance to persistence#6975
Merged
JonnyBurger merged 1 commit intoremotion-dev:mainfrom Apr 4, 2026
Merged
Conversation
Fixes spelling typo in volume-persistance.ts by renaming to volume-persistence.ts and updating the constant DEFAULT_VOLUME_PERSISTANCE_KEY to DEFAULT_VOLUME_PERSISTENCE_KEY. This is a non-breaking internal change that improves code consistency with the already-correct volumePersistenceKey parameter names used throughout the codebase. - Renamed: volume-persistance.ts → volume-persistence.ts - Updated: DEFAULT_VOLUME_PERSISTANCE_KEY → DEFAULT_VOLUME_PERSISTENCE_KEY - Updated: import statement in SharedPlayerContext.tsx All tests pass and formatting checks succeed. Co-authored-by: bhaktofmahakal <113044681+bhaktofmahakal@users.noreply.github.com>
Contributor
|
Reviewed PR #6975 — clean typo fix renaming Task list (4/4 completed)
|
Contributor
There was a problem hiding this comment.
Clean typo fix. The file rename, constant rename, and import update are all consistent — no stale references remain.
Big Pickle (free) ｜ 𝕏
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes spelling typo in volume-persistance.ts by renaming to volume-persistence.ts and updating the constant DEFAULT_VOLUME_PERSISTANCE_KEY to DEFAULT_VOLUME_PERSISTENCE_KEY.
This is a non-breaking internal change that improves code consistency with the already-correct volumePersistenceKey parameter names used throughout the codebase.
All tests pass and formatting checks succeed.