@remotion/studio: 10MB LRU cache for timeline video frames#6960
Merged
JonnyBurger merged 2 commits intomainfrom Apr 1, 2026
Merged
@remotion/studio: 10MB LRU cache for timeline video frames#6960JonnyBurger merged 2 commits intomainfrom
@remotion/studio: 10MB LRU cache for timeline video frames#6960JonnyBurger merged 2 commits intomainfrom
Conversation
Replace count-based frame eviction with a size-based 10MB LRU cache. Frames now persist for the lifetime of the page instead of being cleared on component unmount, improving the experience when scrolling back and forth in the timeline. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed PR #6960 — no actionable issues found. The size-based LRU cache implementation is correct and well-structured. Approved. Task list (5/5 completed)
|
Contributor
There was a problem hiding this comment.
Clean change. Size-based LRU with allocationSize() is the right approach — totalCacheSize tracking is consistent across add/evict/replace paths, lastUsed is updated on both writes (addFrameToCache) and reads (fillWithCachedFrames), and no stale references to the removed exports remain.
Big Pickle (free) ｜ 𝕏
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VideoFrame.allocationSize()Test plan
🤖 Generated with Claude Code