Skip to content

@remotion/studio: Better handling when you forgot to wrap an asset in staticFile()#6958

Merged
JonnyBurger merged 6 commits intomainfrom
feature/media-playback-404-docs
Apr 1, 2026
Merged

@remotion/studio: Better handling when you forgot to wrap an asset in staticFile()#6958
JonnyBurger merged 6 commits intomainfrom
feature/media-playback-404-docs

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

No description provided.

JonnyBurger and others added 5 commits April 1, 2026 10:41
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…backError

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… overlay

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Apr 1, 2026

Reviewed PR #6958. Submitted a review with one nit on the docs (duplicate import statements). The core feature — MediaPlaybackError class, MediaPlaybackErrorExplainer with HEAD probe diagnostics, and the listen-to-runtime-errors.ts fix to preserve instanceof — is solid.

Task list (9/11 completed)
  • Read and review the full diff
  • Review new MediaPlaybackError class
  • Review MediaPlaybackErrorExplainer component
  • Review changes to VideoForPreview and VideoForRendering
  • Review error-overlay integration
  • Review docs changes
  • Check exports and impact
  • Check audio error handling consistency
  • Review RenderModalJSONPropsEditor change
  • Review web-renderer transparency validation removal
  • Submit review

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Big Pickle (free) | 𝕏

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Apr 1, 2026 11:16am
remotion Ready Ready Preview, Comment Apr 1, 2026 11:16am

Request Review

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MediaPlaybackError class + MediaPlaybackErrorExplainer feature is well designed — the HEAD probe that diagnoses 404s and wrong content-types in the error overlay is a great DX improvement. The listen-to-runtime-errors.ts change to pass the full error object (instead of destructuring into a plain object) is the correct fix to preserve instanceof MediaPlaybackError downstream. One nit on the docs.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using Big Pickle (free) | 𝕏

Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>
@JonnyBurger JonnyBurger merged commit bbf013f into main Apr 1, 2026
18 checks passed
@JonnyBurger JonnyBurger deleted the feature/media-playback-404-docs branch April 1, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant