Add stack traces to Composition and improve studio menu bar#6950
Merged
JonnyBurger merged 2 commits intomainfrom Mar 31, 2026
Merged
Add stack traces to Composition and improve studio menu bar#6950JonnyBurger merged 2 commits intomainfrom
JonnyBurger merged 2 commits intomainfrom
Conversation
- Add `stack` field to `TComposition` and register `Composition` with `addSequenceStackTraces` so the bundler proxy injects stack traces - Show composition name in the menu bar as `project / composition` - Make project name a clickable link (opens editor or git repo), replacing the old `OpenEditorButton` icon - Extract `MenuCompositionName` component that resolves the composition stack trace and links to the source location when resolvable - Style slash separator with `LIGHT_TEXT` color - Use `textDecoration: underline` with `textUnderlineOffset: 2` for hover states consistently (menu bar + timeline) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed PR #6950 — no actionable issues found. The stack trace injection for Task list (4/4 completed)
|
Contributor
There was a problem hiding this comment.
Clean PR. The stack field is correctly threaded through TComposition and all fixtures, the JSX proxy injection via addSequenceStackTraces(Composition) follows the established pattern, OpenEditorButton is fully removed with no dangling references, and MenuCompositionName properly resolves stack traces via source maps. No issues found.
Big Pickle (free) ｜ 𝕏
- Make `stack` prop readonly in InnerComposition - Extract stack from compProps before useEffect to satisfy exhaustive-deps - Use Boolean() instead of !! for no-implicit-coercion rule Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stackfield toTCompositionand register<Composition>withaddSequenceStackTracesso the bundler JSX proxy injects stack traces at mount timeproject / compositionwith the project name as a clickable link (replacing the old external-link icon) and the composition name linking to its source location when the stack trace resolvesMenuCompositionNameinto its own component that resolves the composition's stack trace via source maps and opens the editor at the original positiontextDecoration: underlinewithtextUnderlineOffset: 2for hover states consistently across the menu bar and timelineTest plan
project / compositionwhen a composition is selected<Composition>source locationtext-decorationinstead ofborder-bottombun run buildpasses🤖 Generated with Claude Code