@remotion/design: Add theme defaults to register CSS#6938
Merged
JonnyBurger merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
The register entry point (`@remotion/design/register`) only provided a `@source` directive for class scanning. Consumers using `@import '@remotion/design/register'` still needed to manually define all theme variables (`--color-card-bg`, `--color-text`, etc.) for utilities like `bg-card-bg` to resolve correctly. Add `@theme` defaults so the design system works out of the box when the register CSS is imported. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed PR #6938 — no actionable issues found. The theme defaults are correct, match component usage, and both existing consumers ( Task list (5/5 completed)
|
Contributor
There was a problem hiding this comment.
Clean change. The @theme / @theme inline split mirrors src/index.css, the variable names match all component usage (bg-card-bg, text-text, bg-button-bg, text-brand, font-brand, etc.), and both existing consumers (promo-pages and convert) fully override these defaults in their own theme blocks — no breakage risk.
Big Pickle (free) ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@remotion/design/registerentry point only had a@sourcedirective for Tailwind class scanning--color-card-bg,--color-text,--color-button-bg, etc. in their own@themefor design system utilities to resolve@themedefaults to the register CSS so components like Card, Button, and Switch work out of the boxTest plan
@remotion/designcomponents render correctly in consumers using@import '@remotion/design/register'@themeoverrides these defaults)🤖 Generated with Claude Code