Skip to content

@remotion/studio: Fix JSON editor sync during undo/redo#6933

Merged
JonnyBurger merged 2 commits intoremotion-dev:mainfrom
tiwariaayu:#6911
Mar 31, 2026
Merged

@remotion/studio: Fix JSON editor sync during undo/redo#6933
JonnyBurger merged 2 commits intoremotion-dev:mainfrom
tiwariaayu:#6911

Conversation

@tiwariaayu
Copy link
Copy Markdown
Contributor

@tiwariaayu tiwariaayu commented Mar 30, 2026

Removed conditional update logic and ensured the JSON editor always reflects the latest value state, keeping visual and JSON views in sync.

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Mar 30, 2026 •
edited
Loading

Reviewed PR #6933. Found two issues: lastValue ref is dead code (written but never read), and the new useEffect triggers a redundant re-render chain with the existing schema-change effect.

Task list (4/4 completed)
  • Checkout PR and read the diff
  • Read changed file(s) and trace data flow
  • Investigate the issue context and understand the bug being fixed
  • Self-critique comments and submit review
Pullfrog  ｜ [View workflow run](https://github.com/remotion-dev/remotion/actions/runs/23751640877/job/69195059496) ｜ Triggered by [Pullfrog](https://pullfrog.com) ｜ Using `Big Pickle` (free) ｜ [𝕏](https://x.com/pullfrogai)

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Mar 30, 2026 4:07pm
remotion Ready Ready Preview, Comment Mar 30, 2026 4:07pm

Request Review

pullfrog[bot]
pullfrog bot reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core idea — syncing the JSON editor when value changes from undo/redo — is correct, but there are two issues that should be addressed before merging.

Pullfrog  ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Big Pickle (free) ｜ 𝕏

@JonnyBurger JonnyBurger linked an issue Mar 31, 2026 that may be closed by this pull request
Pressing "Undo" in read-only studio does not reset JSON editor #6911
Closed
@JonnyBurger JonnyBurger changed the title @remotion/studio: Fix JSON editor sync during undo/redo @remotion/studio: Fix JSON editor sync during undo/redo Mar 31, 2026
@JonnyBurger
Copy link
Copy Markdown
Member

JonnyBurger commented Mar 31, 2026

Thanks a lot!

@JonnyBurger JonnyBurger merged commit 90348d8 into remotion-dev:main Mar 31, 2026
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pullfrog pullfrog[bot] pullfrog[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pressing "Undo" in read-only studio does not reset JSON editor

2 participants

@tiwariaayu @JonnyBurger