Skip to content

@remotion/studio: Lock cursor during InputDragger and Splitter drag#6929

Merged
JonnyBurger merged 3 commits intomainfrom
feature/force-cursor-during-drag
Mar 30, 2026
Merged

@remotion/studio: Lock cursor during InputDragger and Splitter drag#6929
JonnyBurger merged 3 commits intomainfrom
feature/force-cursor-during-drag

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger commented Mar 30, 2026

Closes #6778

Summary

  • Adds a ForceSpecificCursor overlay component that locks the cursor appearance during drag operations
  • InputDragger now locks the cursor to ew-resize while dragging
  • Splitter handles now lock the cursor to row-resize / col-resize (based on orientation) while dragging
  • Timeline in/out marker handles now lock the cursor to ew-resize while dragging
  • Editor guides/rulers now use the overlay for cursor forcing instead of document.body.style.cursor

Test plan

  • Drag an InputDragger (e.g. position X/Y fields) — cursor stays ew-resize
  • Drag a horizontal splitter (canvas/timeline) — cursor stays row-resize
  • Drag a vertical splitter (sidebar/canvas) — cursor stays col-resize
  • Drag a timeline in/out marker — cursor stays ew-resize
  • Drag a guide from the ruler — cursor shows no-drop then switches to resize cursor when over canvas
  • Drag an existing guide — same cursor behavior
  • All cursors reset to normal after releasing

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Mar 30, 2026

Reviewed PR #6929 — no actionable issues found. The ForceSpecificCursor overlay approach is clean and follows existing codebase conventions (module-level createRef singletons, imperative DOM manipulation for performance-sensitive drag operations). Z-index layering, idempotent calls, and cleanup paths are all sound.

Task list (4/4 completed)
  • Read the PR diff
  • Read full source files for context
  • Analyze changes and draft review
  • Submit review or report progress
Pullfrog  | [View workflow run](https://github.com/remotion-dev/remotion/actions/runs/23749373532/job/69186756382) | Triggered by [Pullfrog](https://pullfrog.com) | Using `Big Pickle` (free) | [𝕏](https://x.com/pullfrogai)

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Mar 30, 2026 3:13pm
remotion Ready Ready Preview, Comment Mar 30, 2026 3:13pm

Request Review

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@JonnyBurger JonnyBurger merged commit 9055af7 into main Mar 30, 2026
18 checks passed
@JonnyBurger JonnyBurger deleted the feature/force-cursor-during-drag branch March 30, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Studio: Add pointer lock

1 participant