Skip to content

@remotion/renderer: Fix imprecise FPS when combining chunks#6908

Merged
JonnyBurger merged 1 commit intomainfrom
fix/exact-fps-in-combine-chunks
Mar 25, 2026
Merged

@remotion/renderer: Fix imprecise FPS when combining chunks#6908
JonnyBurger merged 1 commit intomainfrom
fix/exact-fps-in-combine-chunks

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Summary

  • When combining chunks in distributed rendering (Lambda), the mux step did not specify an explicit framerate (-r), causing ffmpeg to infer a slightly imprecise value from the concatenated stream (e.g. 95940000/3197999 instead of 30/1)
  • Added -r <fps> to the mux command in mux-video-and-audio.ts to force the exact output framerate in the container metadata
  • No re-encoding occurs — with -c:v copy, the -r flag only sets the mp4 container header timing values

Test plan

  • Rendered locally — FPS is 30/1
  • Rendered on Lambda with distributed rendering — FPS is now 30/1 (was 95940000/3197999 before fix)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Mar 25, 2026

Reviewed PR #6908. The change is correct: with -c:v copy, ffmpeg doesn't re-encode, so -r <fps> only writes the precise framerate into the mp4 container header. The fps parameter flows correctly from combineChunks into muxVideoAndAudio. No issues found — approved.

Pullfrog  | View workflow run | Triggered by Pullfrogpullfrog.com𝕏

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Mar 25, 2026 9:07am
remotion Ready Ready Preview, Comment Mar 25, 2026 9:07am

Request Review

@JonnyBurger JonnyBurger merged commit 827eb47 into main Mar 25, 2026
18 checks passed
@JonnyBurger JonnyBurger deleted the fix/exact-fps-in-combine-chunks branch March 25, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant