create-video: Strip control characters from directory name input#6900
Merged
JonnyBurger merged 2 commits intoremotion-dev:mainfrom Mar 23, 2026
Merged
Conversation
Terminal emulators can inject control characters via readline shortcuts (e.g. Ctrl+U inserts U+0015 NAK). These invisible characters cause the project to be created in a phantom directory like `^UDownloads/my-video` instead of `Downloads/my-video`. Strip all C0 control characters (U+0000–U+001F) and DEL (U+007F) from the user's input before using it as a path. Closes remotion-dev#6859 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed PR #6900. The fix is solid — the regex One minor gap: No blocking issues. LGTM with that optional suggestion. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
LGTM too, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^UDownloads/my-videoCloses #6859
Test plan
\x15Downloads/my-video) → control chars are stripped, project created atDownloads/my-video🤖 Generated with Claude Code