Skip to content

@remotion/skills: Remove .mp4 from defaultOutName example#6877

Merged
JonnyBurger merged 1 commit intomainfrom
fix/calculate-metadata-docs
Mar 19, 2026
Merged

@remotion/skills: Remove .mp4 from defaultOutName example#6877
JonnyBurger merged 1 commit intomainfrom
fix/calculate-metadata-docs

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Summary

  • Update calculateMetadata example to omit .mp4 extension from defaultOutName since it is added automatically

Test plan

  • Verify docs render correctly

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Mar 19, 2026

Reviewed PR #6877: "@remotion/skills: Remove .mp4 from defaultOutName example"

Status: Already merged (commit b471aa9 at HEAD)

Change: Updated the defaultOutName example in packages/skills/skills/remotion/rules/calculate-metadata.md from:

defaultOutName: `video-${props.id}.mp4`

to:

defaultOutName: `video-${props.id}` // .mp4 is added automatically

Review: The fix is correct. Remotion automatically appends the file extension based on the codec during rendering, so including .mp4 in defaultOutName would result in double extensions like video-123.mp4.mp4. No actionable feedback needed.

Pullfrog  | View workflow run | Triggered by Pullfrogpullfrog.com𝕏

@vercel vercel bot temporarily deployed to Preview – remotion March 19, 2026 15:02 Inactive
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Mar 19, 2026 3:02pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
remotion Skipped Skipped Mar 19, 2026 3:02pm

Request Review

@JonnyBurger JonnyBurger merged commit 376d9be into main Mar 19, 2026
16 checks passed
@JonnyBurger JonnyBurger deleted the fix/calculate-metadata-docs branch March 19, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant