`@remotion/studio`: Save default props immediately by JonnyBurger · Pull Request #6826 · remotion-dev/remotion

JonnyBurger · 2026-03-06T15:20:19Z

TODO:

Replace polling pattern for default props updatability with server-push subscriptions (mirroring sequence props pattern), apply default props changes immediately on save with server-side HMR suppression, and extract current default props values from the source AST. - Add /api/subscribe-to-default-props and /api/unsubscribe-from-default-props - Remove /api/can-update-default-props polling endpoint - Push 'default-props-updatable-changed' SSE events on root file changes - Extract current defaultProps values from source AST via isStaticValue/extractStaticValue - Handle TSAsExpression nodes (e.g. 'a' as const) in isStaticValue and extractStaticValue - Suppress HMR in update-default-props handler (matching save-sequence-props) - Apply default props optimistically on save, revert on error - Remove client-side remotion_ignoreFastRefreshUpdate usage for default props - Clean up default props watchers on client disconnect Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel · 2026-03-06T15:20:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
bugs	Ready	Preview, Comment	Mar 24, 2026 4:17pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
remotion	Skipped		Mar 24, 2026 4:17pm

Instead of installing a new file watcher per client, use one ref-counted global watcher for the root file. Different clients can subscribe to different compositionIds; on file change, each active compositionId is recomputed and pushed. Also removes debug console.log calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add sendEventToClientId() to LiveEventsServer for targeted delivery. The default props watcher now sends events only to clients that subscribed to the specific compositionId, not to all connected clients. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

pullfrog · 2026-03-06T16:30:32Z

CI fix pushed ✅

Root cause: DataEditor.tsx imported Internals from 'remotion' but never used it, causing TS6133: 'Internals' is declared but its value is never read — which failed the @remotion/studio#make build step (tsgo -d). This cascaded across 7 CI jobs (Linting + Formatting, SSR integration, Lambda integration, Next.js SSR build, and others).

Fix: Removed the unused Internals import from packages/studio/src/components/RenderModal/DataEditor.tsx (line 9).

-import {getInputProps, Internals} from 'remotion';
+import {getInputProps} from 'remotion';

^{｜ View workflow run ｜ Using Cursor CLI ｜ Triggered by Pullfrog ｜ pullfrog.com ｜ 𝕏}

…-dev/remotion into subscribe-default-props

pullfrog · 2026-03-06T17:35:23Z

CI Fix

Failure: @remotion/studio#lint — eslint no-console error at packages/studio/src/components/DefaultPropsEditor.tsx:221

Cause: A debug console.log('onSave', onSave, saving) statement was left in the code.

Fix: Removed the debug console.log statement. Pushed as 91a33c3.

^{｜ View workflow run ｜ Using Cursor CLI ｜ Triggered by Pullfrog ｜ pullfrog.com ｜ 𝕏}

…n-default-props-update

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The HMR suppression mechanism (suppressHmrForFile/shouldSuppressHmr) was a secondary layer that let webpack rebuild but suppressed the HMR notification. suppressBundlerUpdateForFile prevents webpack from seeing the file change entirely via WatchIgnoreNextChangePlugin, which is more efficient. The plugin previously failed for files nested deeper than one level under a watched directory (e.g. src/VisualControls/index.tsx) because watchpack reports ancestor directories (e.g. src/) as changed alongside the file. The plugin only suppressed the immediate parent directory, leaving ancestor directories in changedFiles which triggered a rebuild. Fixed by: - Suppressing callbackUndelayed for ancestor directories of ignored files - Removing ancestor directories from changedFiles in the aggregated callback - Snapshotting ancestor directory timestamps for proper restoration Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Fix navigateToVisualControls: use specific composition selector instead of getByText which matched both folder and composition - Fix subtitle test: exclude checkbox from input selector - Fix extra-rotation test: toggle optional checkbox before interacting with dragger, use regex for flexible file content matching - Clear visual control handles on webpack rebuild - Make extraPlugins required in webpack/rspack config Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pullfrog

Review Summary

This is a substantial PR implementing immediate saving of default props with full undo/redo support and cross-tab synchronization. The architecture is well-designed with proper separation of concerns.

What's Done Well

Architecture: Clean separation between file watchers, undo stack, and live events
Undo/Redo System: Full support for default props, visual controls, and sequence props with 100-entry stacks
Cross-Tab Sync: Proper use of file watchers and SSE for synchronization
HMR Suppression: WatchIgnoreNextChangePlugin elegantly prevents unnecessary rebuilds
API Migration: updateDefaultProps() as deprecated alias maintains backward compatibility
Documentation: Clear migration path with info box about unsavedDefaultProps changes
Tests: Comprehensive e2e coverage for undo/redo and visual controls

Issues to Address

packages/studio-server/src/preview-server/default-props-watchers.ts:139-150 - releaseGlobalWatcher called in loop

The unsubscribeClientDefaultPropsWatchers function calls releaseGlobalWatcher() inside the loop for each composition. While this currently works (because releaseGlobalWatcher checks if (!globalWatcher) at the start), it's fragile:

for (const compositionId of Object.keys(subscriptions)) {
  if (subscriptions[compositionId].has(clientId)) {
    subscriptions[compositionId].delete(clientId);
    // ...
    releaseGlobalWatcher(); // Called multiple times in loop
  }
}

Consider counting the total subscriptions to release and calling releaseGlobalWatcher() once after the loop:

export const unsubscribeClientDefaultPropsWatchers = (clientId: string) => {
  let shouldRelease = false;
  for (const compositionId of Object.keys(subscriptions)) {
    if (subscriptions[compositionId].has(clientId)) {
      subscriptions[compositionId].delete(clientId);
      if (subscriptions[compositionId].size === 0) {
        delete subscriptions[compositionId];
      }
      shouldRelease = true;
    }
  }
  if (shouldRelease) {
    releaseGlobalWatcher();
  }
};

packages/studio-server/src/preview-server/default-props-watchers.ts:100-104 - Redundant delete-then-add

When subscribing the same client+composition pair, the code first deletes and releases, then immediately adds and ensures. While the net refCount is correct, this is unnecessary churn:

if (subscriptions[compositionId]?.has(clientId)) {
  subscriptions[compositionId].delete(clientId);
  releaseGlobalWatcher(); // Release first
}
// ... 
subscriptions[compositionId].add(clientId);
ensureGlobalWatcher(rootFile); // Then acquire

Consider skipping the delete+release if the root file hasn't changed.

packages/studio-server/src/preview-server/default-props-watchers.ts:53 - No error handling

The onChange callback in ensureGlobalWatcher lacks try/catch around computeCanUpdateDefaultPropsFromContent. If this throws, the error won't be caught.

Minor Observations

The WatchIgnoreNextChangePlugin relies heavily on webpack internals (watchpack, NodeWatchFileSystem). This could break with webpack version updates. Consider adding a comment noting this dependency.
The watchIgnorePlugin trace is set up before setWatchIgnoreNextChangePlugin is called, which is correct. Good design.

Verification

The TODO items are mostly checked off. The two unchecked items ("Should print good console messages" and "Should skip prettier and log") appear to have partial implementations but may need more work before merge.

^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ pullfrog.com ｜ 𝕏}

pullfrog · 2026-03-24T14:14:23Z

packages/studio-server/src/preview-server/default-props-watchers.ts

+	releaseGlobalWatcher();
+};
+
+export const unsubscribeClientDefaultPropsWatchers = (clientId: string) => {


Consider calling releaseGlobalWatcher() once after the loop instead of inside it for each composition. While the current code works (because releaseGlobalWatcher checks if (!globalWatcher)), it's fragile and could cause issues if the logic changes.

- Restart studio server before each test for full isolation - Wait for source map resolution before interacting with visual controls (the save endpoint was never called when originalFileName was still loading) - Clear visual control unsaved overrides when code value changes instead of wiping all handles on build completion (preserves originalFileName state) - Add trace logging to save endpoints for debugging - Make extraPlugins required in webpack/rspack config Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Run e2e tests via turborepo so upstream packages (CLI, studio, etc.) are built before the tests run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The schema editor test was failing in CI because it edited props before the subscribe-to-default-props API call resolved, meaning saves to the source file were not yet active. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

vercel bot deployed to Preview – bugs March 6, 2026 15:20 View deployment

vercel bot deployed to Preview – remotion March 6, 2026 15:22 View deployment

vercel bot deployed to Preview – bugs March 6, 2026 16:08 View deployment

vercel bot deployed to Preview – bugs March 6, 2026 16:09 View deployment

vercel bot deployed to Preview – remotion March 6, 2026 16:10 View deployment

we don't have to do that

a3d3d5e

vercel bot deployed to Preview – bugs March 6, 2026 16:24 View deployment

vercel bot had a problem deploying to Preview – remotion March 6, 2026 16:25 Failure

Remove unused Internals import in DataEditor.tsx

fa4f5d3

vercel bot deployed to Preview – bugs March 6, 2026 16:36 View deployment

JonnyBurger added 2 commits March 6, 2026 17:38

default props refactor

0269bfc

Merge branch 'subscribe-default-props' of https://github.com/remotion…

4b23258

…-dev/remotion into subscribe-default-props

vercel bot deployed to Preview – bugs March 6, 2026 16:38 View deployment

vercel bot deployed to Preview – remotion March 6, 2026 16:40 View deployment

delete save and reset button

544aad1

vercel bot deployed to Preview – bugs March 6, 2026 17:04 View deployment

delete more instances

bb1541a

vercel bot deployed to Preview – remotion March 6, 2026 17:06 View deployment

vercel bot deployed to Preview – bugs March 6, 2026 17:07 View deployment

vercel bot deployed to Preview – remotion March 6, 2026 17:08 View deployment

remove unsaved value code

9a337f7

vercel bot deployed to Preview – bugs March 6, 2026 17:24 View deployment

vercel bot deployed to Preview – remotion March 6, 2026 17:26 View deployment

Remove debug console.log in DefaultPropsEditor

91a33c3

JonnyBurger added 4 commits March 20, 2026 15:18

Update watch-ignore-next-change-plugin.ts

08b9352

Merge pull request #6889 from remotion-dev/suppress-webpack-rebuild-o…

25605aa

…n-default-props-update

nice

2ea6f4c

cool

343dfb2

This was referenced Mar 23, 2026

#6870 Studio: <Img> should also show up as a layer #6892

Merged

@remotion/studio: Consolidate SSE connections to fix multi-tab hanging #6887

Merged

JonnyBurger and others added 13 commits March 23, 2026 11:03

updateDefaultProps is an alias for saveDefaultProps

344056a

Merge branch 'main' into subscribe-default-props

724fc2c

Add @deprecated JSDoc tag to updateDefaultProps and update docs

38ca4f6

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

visual controls testbed

2dd576d

e2e for updating values

a28b3e8

awesome

47cb69e

cool

b760413

yes

8423fe7

cool

727cfd3

awesome

57fa661

mandatory

6419cbf

pullfrog bot reviewed Mar 24, 2026

View reviewed changes

JonnyBurger and others added 10 commits March 24, 2026 15:34

Merge branch 'main' into subscribe-default-props

f498c8f

Update document-title.ts

8bd6913

Update ObserveDefaultPropsContext.tsx

1b0b44e

update shortcuts

769dda4

cool

1df42a6

Update push.yml

d33b08a

reset

673536c

Add example e2e tests to CI browser-tests job

1c4185a

Run e2e tests via turborepo so upstream packages (CLI, studio, etc.) are built before the tests run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`@remotion/studio`: Save default props immediately#6826

`@remotion/studio`: Save default props immediately#6826
JonnyBurger merged 83 commits intomainfrom
subscribe-default-props

JonnyBurger commented Mar 6, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

pullfrog bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

pullfrog bot commented Mar 6, 2026 •

edited

Loading

Uh oh!

pullfrog bot left a comment

Uh oh!

pullfrog bot Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

JonnyBurger commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pullfrog bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pullfrog bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Fix

Uh oh!

pullfrog bot left a comment

Choose a reason for hiding this comment

Review Summary

What's Done Well

Issues to Address

Minor Observations

Verification

Uh oh!

pullfrog bot Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JonnyBurger commented Mar 6, 2026 •

edited

Loading

vercel bot commented Mar 6, 2026 •

edited

Loading

pullfrog bot commented Mar 6, 2026 •

edited

Loading

pullfrog bot commented Mar 6, 2026 •

edited

Loading