feat: Allow to set per-composition render defaults#3022
Merged
JonnyBurger merged 11 commits intoremotion-dev:mainfrom Oct 20, 2023
Merged
feat: Allow to set per-composition render defaults#3022JonnyBurger merged 11 commits intoremotion-dev:mainfrom
JonnyBurger merged 11 commits intoremotion-dev:mainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
@mnmt7 Thanks a lot! 🙌 Will review it soon! Yes, indeed the |
JonnyBurger
previously approved these changes
Oct 19, 2023
Member
JonnyBurger
left a comment
There was a problem hiding this comment.
Nicely done! Thanks a lot!
JonnyBurger
previously approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2487
/claim #2487
Video - https://jam.dev/c/cd4ec8d1-32cc-4ae9-a343-7a4b63857d2a
@JonnyBurger , I created a codec.ts file in the core package similar to the one in the renderer package. So, now there are 2 codec.ts files. Now, I could have just removed the codec.ts file in the renderer package and made the appropriate changes but I just wanted to confirm with you if you are fine with this approach before proceeding further.