Skip to content

Add <Credits> component to shout out contributors#3009

Merged
JonnyBurger merged 17 commits intoremotion-dev:mainfrom
evoxf1:main
Oct 16, 2023
Merged

Add <Credits> component to shout out contributors#3009
JonnyBurger merged 17 commits intoremotion-dev:mainfrom
evoxf1:main

Conversation

@evoxf1
Copy link
Copy Markdown
Contributor

@evoxf1 evoxf1 commented Oct 14, 2023

Pull Request Description

This pull request addresses issue #3001.

Changes Made

I added a new Credit component to the project. This component accepts props to display contributors' information, including their photo, GitHub profile link, and the contribution they made to the project.

Related Issues

Test Suite

I have tested the Credit component with various props to ensure it displays contributors' information correctly. The existing test suite passes after the addition of this component.

Potential Tradeoffs

No significant tradeoffs were made during the implementation of this feature. The component is designed to be flexible and easy to use, allowing project contributors to showcase their information easily.

Checklist

/claim #3001

evoxf1 and others added 12 commits October 13, 2023 11:20
* fix default creds

* add checking of environment

* write output files

* makes sense

* show render output

* alright

* selected output

* scroll into view if already selected

* preview toolbar refactor

* Update PreviewToolbar.tsx

* commit

* get asset metadata

* Update FilePreview.tsx

* make it a constant

* bump `bounty.list` page limit

* Update bounty.md

* `remotion`: Fix float imprecisions for <Sequence> + add test

* respect logLevel in lambda merge function

* `@remotion/lambda`: Log merging progress

* v4.0.44

* Update bundle-installer.ts

* v4.0.45

* Bump postcss from 8.4.18 to 8.4.31

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.18 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.18...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* simulate lambda: enforceAudioTrack like in lambda

* Docs: New formatting guide for contributors

* link from main page

* use priority on which credential to use

* parametrize audio bitrate

* More frequent progress logging for Lambda during combination phase

* new fdk command

* add fraunhofer aad into rust binaries

* only set audio bitrate if so desired

* confirmed it is faster

* add test cases

* always set audio bitrate for now

* Bump zod from 3.21.4 to 3.22.3

Bumps [zod](https://github.com/colinhacks/zod) from 3.21.4 to 3.22.3.
- [Release notes](https://github.com/colinhacks/zod/releases)
- [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md)
- [Commits](colinhacks/zod@v3.21.4...v3.22.3)

---
updated-dependencies:
- dependency-name: zod
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* chromiumOptions can be null

* upgrade @typescript-eslint to latest

* v4.0.46

* make console test use getProjectId()

* Update RenderParams.php

* PHP: Extract GetRenderProgressResponse into separate file

* Docs: Update Lambda claims

* chore(docs): update easings doc with clear signatures to bounce and beizer

* chore: add number signature to the othereasing functions

* Rename companies.remotion.dev to remotion.pro and introduce Remotion Store

* fix bezier typo and update function signatuer

* feat: add library starter docs

* Update showcase-videos.tsx

Add Delba's video: https://twitter.com/delba_oliveira/status/1707439537054535867

* update eslint

* fix some formatting

* Update showcase-videos.tsx

* Update showcase-videos.tsx

* new eslint styles

* `@remotion/renderer`: Fix multiple bugs keeping event loop running for too long

* Add two new tutorials

* simplified browser close logic

* shuffle around for more performance

* Discard changes to packages/lambda/src/functions/helpers/get-browser-instance.ts

* revert to old getBrowserInstance()

* Update Browser.ts

* make forgetEventLoop() and rememberEventLoop() methods

* forgetEventLoop

* properly forget and remember event loops

* kill browser instance when configuration has changed

* fixing dead link in docs

* fix signature

* `@remotion/cli`: Fix --no-open flag

* author a remotion library

* doc structure

* v4.0.47

* `@remotion/gif`: Only clear portion of canvas drawn when encountering disposalType = 2

* deploy the studio

* use node 20 in general

* Update deploy-remotion-studio.md

* add render.com instructions

* and digitalocean (does not work yet)

* Remotion Studio: Supports PORT environment variable

* `@remotion/renderer`: Use 0.0.0.0 for port selection

* hmm wonder if that works

* v4.0.48

* Update deploy-remotion-studio.md

* Update deploy-remotion-studio.md

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Alex Fernandez <7582277+alexfernandez803@users.noreply.github.com>
Co-authored-by: Jonny Burger <jonathanburger11@gmail.com>
Co-authored-by: zafer <zafer@algora.io>
Co-authored-by: MehmetAdemi <mehmet@remotion.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kaf-lamed-beyt <belac335@gmail.com>
Co-authored-by: Mohit Yadav <www.mohit2004@gmail.com>
Co-authored-by: Mehmet <86873911+MehmetAdemi@users.noreply.github.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs 🛑 Canceled (Inspect) Oct 16, 2023 1:46pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 1:46pm

@IamSAL
Copy link
Copy Markdown

IamSAL commented Oct 14, 2023

On dark mode, name stays black. it should be something lighter/white instead.

image

@evoxf1
Copy link
Copy Markdown
Contributor Author

evoxf1 commented Oct 14, 2023

Untitled

tried something please do check, also @IamSAL thanks for the feedback you are awesome for pointing it out, I was completely unaware of the same.

Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@JonnyBurger JonnyBurger changed the title Fix for Issue #3001 Add <Credits> component to shout out contributors Oct 16, 2023
@vercel vercel bot temporarily deployed to Preview – bugs October 16, 2023 13:46 Inactive
@evoxf1
Copy link
Copy Markdown
Contributor Author

evoxf1 commented Oct 16, 2023

Thanks! 🙌

Anytime. 🙌

@JonnyBurger JonnyBurger merged commit e2db2f9 into remotion-dev:main Oct 16, 2023
JonnyBurger added a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a "credits" component for the documentation

3 participants