Fixes #2932 - Allow a toneFrequency prop to be passed to <Audio> for changing the pitch.#2979
Fixes #2932 - Allow a toneFrequency prop to be passed to <Audio> for changing the pitch.#2979JonnyBurger merged 31 commits intoremotion-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JonnyBurger
left a comment
There was a problem hiding this comment.
This goes into the right direction.
However, the PR did not actually work, it was not actually possible to pass a prop and then the filter was not actually applied to the audio. I helped a bit here!
Now it works, but I noticed regarding documentation and validation there is one major flaw:
It is currently implemented to take values between 0 and 1, however 1 is the normal pitch, and a value like 1.2 will make the pitch 20% higher, while a value like 0.8 will make the pitch 20% lower.
It is not a range between 0 and 1.
Can you fix this in the validation logic and documentation?
|
Ya sure it can be fixed maybe altering the function, so according to you the pitch should be between 0-2, meaning value less that one will reduce the pitch and more than 1 will increase? |
|
/approve |
|
Could not find a claim that corresponds to the PR. Please add the |
|
/approve |
|
@JonnyBurger: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
Issue
Fixes #2932
Description
This PR addresses issue #2932 by introducing the
toneFrequencyprop to the<Audio>component. ThetoneFrequencyprop allows users to specify the pitch adjustment for audio playback, with a valid range from 0.01 to 2(0 being not assignable). This feature enables precise control over audio pitch during rendering.Changes Made
toneFrequencyprop to the<Audio>component, allowing users to control pitch adjustment during audio playback.toneFrequencyprop, specifying its usage and valid range.toneFrequencyprop.Tradeoffs Considered
Not at the moment.
How to Test
Please refer to audio.md Docs.
/claim #2932