feat: gut bash/exec tools, PTY, and exec-approval infrastructure (#70)#71
Merged
alexey-pelykh merged 1 commit intomainfrom Feb 27, 2026
Merged
feat: gut bash/exec tools, PTY, and exec-approval infrastructure (#70)#71alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Remove the OpenClaw bash/exec tool subsystem, PTY terminal handling, and exec-approval security infrastructure. RemoteClaw's CLI agents handle their own shell execution natively, making this infrastructure dead code. Deleted ~95 files (~22k lines) across: - Bash tool creation (exec, process, approval request flows) - PTY adapter and key handling - Exec-approval manager, forwarder, and CLI - Exec-safety, safe-bin policy, runtime policy, trust - System-run-command resolution and obfuscation detection - Exec-wrapper resolution - Channel exec-approval handlers (Discord, gateway, CLI) - Related test files Surviving code changes: - pi-tools.ts: removed exec/process tool creation, kept apply_patch - supervisor.ts: removed PTY spawn branch, child-only now - invoke.ts, invoke-system-run.ts: stubbed gutted exec-approval and exec-host types/functions for backward compatibility - Extracted isSafeExecutableValue to src/infra/safe-executable-value.ts (general-purpose validation, still used by config) - bash-tools.ts: type-only stub for pi-embedded-runner compatibility - Cleaned up imports in ~30 surviving files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 27, 2026
This was referenced Mar 12, 2026
alexey-pelykh
added a commit
that referenced
this pull request
Mar 17, 2026
Remove references to gutted fork infrastructure that cherry-picked upstream commits still referenced: exec-command-resolution, exec-safe-bin-runtime-policy, exec-safe-bin-trust modules (deleted in fork #70/#71), ExecApprovalManager/createExecApprovalHandlers (gutted exec-approval infra), and loadBundledMemoryPluginRegistry (gutted memory subsystem). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexey-pelykh
added a commit
that referenced
this pull request
Mar 17, 2026
Remove references to gutted fork infrastructure that cherry-picked upstream commits still referenced: exec-command-resolution, exec-safe-bin-runtime-policy, exec-safe-bin-trust modules (deleted in fork #70/#71), ExecApprovalManager/createExecApprovalHandlers (gutted exec-approval infra), and loadBundledMemoryPluginRegistry (gutted memory subsystem). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexey-pelykh
added a commit
that referenced
this pull request
Apr 27, 2026
…2606) The gateway handlers for `exec.approval.{request,waitDecision,resolve}` were deleted by PR #2375 (commit 4e84640, 2026-04-16) — themselves zero-caller stubs at that point, after the original implementation was gutted by PR #70/#71 (commit 45d6734, 2026-02-27). The protocol-level declarations (method-scopes, server-methods-list, schemas, validators, broadcast scope guards) and live RPC callers (TS agents node-tool, CLI nodes-cli register.invoke, web UI app.ts, macOS GatewayConnection + ExecApprovalsGatewayPrompter) survived. Net result: an unreachable RPC surface where every live caller would receive `INVALID_REQUEST: unknown method: exec.approval.*` from the gateway today. The audit (`docs/refactor/exec-approval-singular-audit-2606.md`) walks each of #2606's four acceptance criteria with file:line evidence, documents the subsystem split (singular `exec.approval.*` request/decision flow vs plural `exec.approvals.*` policy/storage — the latter is in active use and out of scope), confirms zero broadcast producers exist for `exec.approval.{requested,resolved}` events, and verifies that no shared correlation shape would be worth extracting before deletion. Documentation finding: `docs/concepts/exec-approvals-architecture.md` was written 2026-04-26 (10 days after the singular handlers were deleted by PR #2375) and still asserts "End-to-end functional" for this path. The audit doc is now the authoritative current-status reference. This PR is audit-only — restore-vs-full-gut is a follow-up sized after this lands, per the issue body. Recommendations live at the end of the audit doc. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8 tasks
alexey-pelykh
added a commit
that referenced
this pull request
Apr 27, 2026
…2606) (#2609) The gateway handlers for `exec.approval.{request,waitDecision,resolve}` were deleted by PR #2375 (commit 4e84640, 2026-04-16) — themselves zero-caller stubs at that point, after the original implementation was gutted by PR #70/#71 (commit 45d6734, 2026-02-27). The protocol-level declarations (method-scopes, server-methods-list, schemas, validators, broadcast scope guards) and live RPC callers (TS agents node-tool, CLI nodes-cli register.invoke, web UI app.ts, macOS GatewayConnection + ExecApprovalsGatewayPrompter) survived. Net result: an unreachable RPC surface where every live caller would receive `INVALID_REQUEST: unknown method: exec.approval.*` from the gateway today. The audit (`docs/refactor/exec-approval-singular-audit-2606.md`) walks each of #2606's four acceptance criteria with file:line evidence, documents the subsystem split (singular `exec.approval.*` request/decision flow vs plural `exec.approvals.*` policy/storage — the latter is in active use and out of scope), confirms zero broadcast producers exist for `exec.approval.{requested,resolved}` events, and verifies that no shared correlation shape would be worth extracting before deletion. Documentation finding: `docs/concepts/exec-approvals-architecture.md` was written 2026-04-26 (10 days after the singular handlers were deleted by PR #2375) and still asserts "End-to-end functional" for this path. The audit doc is now the authoritative current-status reference. This PR is audit-only — restore-vs-full-gut is a follow-up sized after this lands, per the issue body. Recommendations live at the end of the audit doc. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #70
Remove the OpenClaw bash/exec tool subsystem, PTY terminal handling, and exec-approval security infrastructure. RemoteClaw's CLI agents handle their own shell execution natively, making this infrastructure dead code.
src/infra/safe-executable-value.ts— extracted general-purpose validation function still used by configTest plan
pnpm buildpassespnpm testpasses (1444 test files, 12,062 tests, 0 failures)pnpm checkpasses (format + typecheck + lint, no new type errors)src/process/exec.tspreserved (general-purpose utility used by 61 files)🤖 Generated with Claude Code