gut(auth): remove dead auth profile consumers (#426)#486
Merged
alexey-pelykh merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
Remove per-session auth profile override system and all its consumers, now replaced by per-agent auth config (#421). Deleted: - src/auto-reply/reply/directive-handling.auth.ts (/auth directive handler) - src/auth/session-override.ts (per-session auth profile override) Removed from session/queue types: - authProfileOverride, authProfileOverrideSource (SessionEntry) - authProfileId, authProfileIdSource (FollowupRun) Removed from production code: - resolveModelAuthLabel, formatApiKeySnippet (provider-auth.ts) - resolveProfileOverride consumer (directive-handling.persist.ts) - resolveSessionAuthProfileOverride calls (get-reply-run.ts, cron/run.ts) - Auth profile validation block (commands/agent.ts) - Auth override cleanup (sessions-patch.ts, session-status-tool.ts) - Auth label display in status output (status.ts, commands-status.ts) - resolveRunAuthProfile, resolveProviderScopedAuthProfile (agent-runner-utils.ts) Kept: resolveModelAuthMode (used for cost estimation), core auth profile store, resolveApiKeyForProvider, rotation logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directive-handling.auth.ts(/auth directive handler) andsession-override.ts(per-session override system)authProfileOverride/authProfileOverrideSourcefrom SessionEntry,authProfileId/authProfileIdSourcefrom FollowupRun queue typeresolveModelAuthLabel, auth label display from status output, auth profile validation fromcommands/agent.ts, and auth override cleanup from sessions-patch/session-status-toolresolveModelAuthMode(cost estimation), core auth profile store,resolveApiKeyForProvider, rotation logic24 files changed, +22 / -634 lines (2 files deleted, 22 modified)
Part of #415 (Phase 5, item 16). Closes #426.
Test plan
pnpm checkpasses (format + typecheck + lint)pnpm testunit tests pass (978 files, 8209 tests)authProfileOverride,resolveModelAuthLabel,resolveProfileOverride,clearSessionAuthProfileOverride,session-overrideimports,directive-handling.authimports)resolveModelAuthMode,resolveApiKeyForProvider, core auth store)🤖 Generated with Claude Code