spike(test): UI test-layer fixture audit — zero findings (#2528)#2545
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 24, 2026
Merged
spike(test): UI test-layer fixture audit — zero findings (#2528)#2545alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Audit `ui/src/**/*.test.ts` for fixtures referencing gutted features (skills marketplace + thinking-level state drivers per #2336 Area 7/8). Result: zero hits across all 7 target tokens — `skills`, `Skills`, `agentSkills`, `autoAllowSkills`, `thinkingLevel`, `chatThinkingLevel`, `thinkLevel`. Cross-verification with case-insensitive sweep of the full `ui/src/` tree confirms prior gut sweeps (#2524, #2536, #2539, #2480) purged the tokens at the source, not just in tests. No DEAD FIXTURE, no MOCK SHIELD, no follow-up issues needed. All 15 UI `vi.mock` call sites target live modules only — no analog to the `runPreparedReply` shield that motivated this spike. Typed exception: SPIKE — AC is the audit inventory, not code changes. Deliverable lives at `docs/refactor/ui-test-fixture-audit-2528.md`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui/src/**/*.test.tsfor fixtures referencing gutted features per spike(test): audit UI test-layer for gutted-feature fixtures and mock shields #2528 (post-gut(auto-reply): finish thinking-level and model-selection sweep — follow-up to #2335 #2336 Area 8 extension into the UI test suite).skills,Skills,agentSkills,autoAllowSkills,thinkingLevel,chatThinkingLevel,thinkLevel.What's in this PR
Single new doc:
docs/refactor/ui-test-fixture-audit-2528.md— the audit inventory, method, cross-verification against recent gut sweeps, adjacent non-target reference table, and #2336 Area 7 production-code follow-through spot check.Typed exception: SPIKE — AC is the audit inventory, not test modifications.
Why zero findings
The UI test suite has no residue because prior sweeps (#2524/#2535, #2536, #2539/#2542, #2480) purged the target tokens at the source, not just in tests. The legacy-migration
strip-thinking-level-fields(src/config/legacy.migrations.ts:45) additionally scrubs historical fields from on-disk configs. All 15 UIvi.mockcall sites target live modules — no analog to therunPreparedReplyshield from #2336 Area 8.AC
Test plan
pnpm format:checkgreenpnpm tsgogreen (no TS changes)pnpm lintgreen (no code changes)pnpm lint:tmp:no-random-messaginggreenpnpm lint:no-remoteclaw-aigreenpnpm lint:ui:no-css-class-driftgreenpnpm checkaggregate passedCloses #2528
🤖 Generated with Claude Code