Skip to content

gut(ui): strip residual skills* handlers/state/CSS — completes #2536 follow-up (#2539)#2542

Merged
alexey-pelykh merged 1 commit intomainfrom
gut/2539-skills-residue
Apr 24, 2026
Merged

gut(ui): strip residual skills* handlers/state/CSS — completes #2536 follow-up (#2539)#2542
alexey-pelykh merged 1 commit intomainfrom
gut/2539-skills-residue

Conversation

@alexey-pelykh
Copy link
Copy Markdown

Summary

Follow-up gut wave to #2536 (commit 80d311d25a), removing skills subsystem residue that the prior sweep missed in the agents view.

Closes #2539.

What changed

File Removed
ui/src/ui/app-view-state.ts 6 orphan state fields (skillsLoading, skillsError, skillsFilter, skillEdits, skillMessages, skillsBusyKey) + 6 orphan handler type declarations (handleInstallSkill, handleUpdateSkill, handleToggleSkillEnabled, handleUpdateSkillEdit, handleSaveSkillApiKey, handleLoadSkills) + orphan SkillMessage type alias + its eslint-disable comment
ui/src/ui/views/agents-utils.ts skills?: string[] on AgentConfigEntry; skillsLabel on AgentContext; skillFilter/skillCount/skillsLabel computation
ui/src/ui/views/agents-panels-status-files.ts "Skills Filter" row from the Agent Context card (4 lines)
ui/src/styles/components.css 13 CSS rules (.agent-skills-*, .skills-grid + container-query variant) at lines 3371-3441
ui/src/i18n/locales/{pt-BR,zh-CN,zh-TW}.ts Orphan cards.skills entries — canonical en.ts does not define this key (residue from #2536's i18n sweep)

Diff: 7 files, 98 deletions, 0 additions. Zero runtime impact.

Scope clarification vs issue body

Discovered during implementation, all already anticipated in issue #2539's Change list:

Out of scope (follow-up)

The remaining `cards.{cost,recentSessions}` entries in pt-BR/zh-CN/zh-TW are ALSO orphans — canonical `en.ts` has no `cards` block at all. This is a broader i18n coverage-gap issue, not skills-specific, and is left for a dedicated sync wave.

Verification

All AC from #2539 satisfied:

  • `rg -n 'skillsLoading|skillsError|skillsFilter|skillsBusyKey' ui/src/` returns zero hits
  • `rg -n 'skillsLabel' ui/src/` returns zero hits
  • No `@state` decorators on `RemoteClawApp` reference `skills*` (grep confirmed)
  • `pnpm check` green (format + tsgo + oxlint + rebrand-gate + CSS class drift 0 orphans)
  • `pnpm test` green (800 files, 7014 passed, 3 skipped pre-existing)
  • `pnpm test:ui:smoke` green (2 files, 12/12 tests)

Adversarial validation: no dynamic string references to removed classes; no reflective reads of removed state; no test references; no `SkillMessage` imports anywhere; `agents-overview-grid` auto-fit layout flows cleanly with 4 rows instead of 5.

Test plan

  • CI: lint + build + test + test-ui-smoke
  • Fork-integrity gates: rebrand + zombie-import + stub-debt + css-class-drift all pass

…follow-up (#2539)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gut(ui): strip residual skills* handlers/state/CSS from agents view

1 participant