chore(obsolescence-audit): drop stale commands-models.ts pattern entries (#2452)#2453
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
…ies (#2452) Both `buildModelsProviderData` and `handleModelsCommand` entries referenced `src/auto-reply/reply/commands-models.ts`, which was deleted in #2373 (commit c61609d). The audit script treats patterns whose files don't exist as "resolved" (scripts/check-obsolescence-audit.mjs:294), so both entries were already inert — removing them reduces dead tracking data without changing audit coverage. Total findings unchanged at 50 (50 stubs + 0 known patterns, baseline 134). Sibling `handleModelsCommand` removed under the same root cause, confirmed by user as in-scope for this cleanup even though #2452 names only `buildModelsProviderData`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildModelsProviderDataandhandleModelsCommand) fromscripts/data/obsolescence-known-patterns.json. Both referenced the deleted filesrc/auto-reply/reply/commands-models.ts(tombstoned in gut: eliminate callers and delete ~14 EXCLUDE-STUB files in src/auto-reply/ #2373, commitc61609dc26).scripts/check-obsolescence-audit.mjs:294) treats patterns whose files don't exist as "resolved", so both entries were already inert. Removing them cleans up dead tracking data without changing audit coverage.Root cause
The issue title names only
buildModelsProviderData, but the sibling entryhandleModelsCommandin the same file had the identical problem. Both entries became inert in #2373 when their referenced file was deleted. The description staleness called out in #2452 was a downstream symptom — the entries had actually been resolving to ENOENT on the audit script for weeks.Confirmed with the reporter that both should be removed under the same PR (Option 2 from the issue).
Test plan
node scripts/check-obsolescence-audit.mjs→ exit 0 (local)Array.isArray(patterns) === true(structural check — script requires it at line 164)src/ extensions/ ui/→ zero hitsOut of scope (noted, not addressed)
.obsolescence-baseline = 134vs actual50— pre-existing drift, not caused by this PR. Audit script's "debt decreased" message is informational, not a gate failure. Belongs in a separate cleanup.docs/.generated/plugin-sdk-api-baseline.jsonstill references the deleted file for 4 exports.scripts/generate-plugin-sdk-api-baseline.tsis not wired into any npm script or CI workflow, so that artifact has drifted separately. Belongs in its own issue.Closes #2452.