Status

After #2450 (Discord model-picker gut) + #2451 (Mattermost model-picker gut, both merged 2026-04-21), the `buildModelsProviderData` entry in `scripts/data/obsolescence-known-patterns.json` has a stale description.

Current entry

```json
{
"category": "broken_contract",
...
"identifier": "buildModelsProviderData",
"description": "Stub returns {} but Discord/Mattermost model-picker UI still calls it — users see empty model lists",
"issue": "#2337"
}
```

Evidence of staleness

`git grep buildModelsProviderData` returns only two files:

• `docs/.generated/plugin-sdk-api-baseline.json` (generated artifact — not a caller)
• `scripts/data/obsolescence-known-patterns.json` (the pattern entry itself)

No source-code callers remain. The "Discord/Mattermost model-picker UI still calls it" claim is false after #2450 + #2451.

Options

1. Update description — reframe as "Stub returns {} but remains exported from plugin SDK (no live source callers after gut(discord): remove dead model-picker UI — CLI agents own model selection (#2414) #2450 + gut(mattermost): remove dead model-picker UI — CLI agents own model selection (#2449) #2451)".
2. Remove entry entirely — pattern is no longer an active broken contract; the stub function has no callers.
3. Remove the stub itself — if `buildModelsProviderData` is exported from `src/agents/` or similar and has zero real callers after the picker guts, delete the stub. This requires confirming that `docs/.generated/plugin-sdk-api-baseline.json` regenerates without it (if it's a plugin SDK export, removing may cause SDK API drift — evaluate).

Context

Surfaced during polish phase of #2449 / PR #2451 (Mattermost model-picker gut). Not blocking; tracked separately to keep #2449's scope tight.

Relation

• Closes nothing on its own (cleanup).
• Part of gut: re-apply provider/model cascade after v2026.3.7 sync regression (~19 files) #2337 follow-up pattern cleanup.
• Follows gut(discord): remove dead model-picker UI — CLI agents own model selection (#2414) #2450, gut(mattermost): remove dead model-picker UI — CLI agents own model selection (#2449) #2451.