ci(fork-sync): strip dangling ADR path references (#2434)#2443
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 20, 2026
Merged
ci(fork-sync): strip dangling ADR path references (#2434)#2443alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
CI scripts referenced `engineering/decisions/0005-fork-sync-hardening.md` and `engineering/notes/provider-model-obsolescence-audit.md` but neither directory exists in this repo — the referenced docs live only in the private HQ. Contributors hitting these gates could not resolve the paths. Decision: ADRs stay HQ-internal; CI keeps the rule names only (`ADR 0005 H5`, `ADR 0005 H6`) as stable identifiers without broken paths. - check-stub-debt.mjs:13: strip path from header comment - check-obsolescence-audit.mjs:34: strip path from header comment - check-obsolescence-audit.mjs:357: strip path from FAIL error message Unblocks #2435, #2436, #2437 from the #2433 hardening epic — none require an ADR file to exist in this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI scripts referenced an ADR file path that doesn't exist in this repo. Per the decision on #2434, ADRs stay in the private HQ and CI keeps only the stable rule names (
ADR 0005 H5,ADR 0005 H6) — no broken paths.Changes
scripts/check-stub-debt.mjs:13— strip(engineering/decisions/0005-fork-sync-hardening.md)from header commentscripts/check-obsolescence-audit.mjs:34— strip(engineering/decisions/0005-fork-sync-hardening.md)from header commentscripts/check-obsolescence-audit.mjs:357— strip, engineering/notes/provider-model-obsolescence-audit.mdfrom FAIL error messagescripts/check-stub-debt.mjs:108was already correct (rule name only) and is not touched.Verification
node scripts/check-stub-debt.mjs→ exit 0,Stub debt check passed: 12 == baseline 12.node scripts/check-obsolescence-audit.mjs→ exit 0grep -rn "engineering/decisions\|engineering/notes" .(excluding build dirs) → no matches; unrelated npm scope@martian-engineering/*correctly excluded.tmp/validate-intent.task.jsonl)pnpm checkpre-commit hook: format + lint + custom gates all passCascade impact
Unblocks #2435, #2436, #2437 from the #2433 hardening epic — none require an ADR file to exist in this repo.
Test plan
ADR 0005 H5,ADR 0005 H6) preserved as stable identifiersCloses #2434.