Skip to content

ci(fork-sync): strip dangling ADR path references (ADR stays HQ-internal) #2434

@alexey-pelykh

Description

@alexey-pelykh

Problem

Two CI scripts reference an ADR file path that does not exist in this repo:

  • scripts/check-stub-debt.mjs:13 — comment: Reference: ADR 0005 H5 (engineering/decisions/0005-fork-sync-hardening.md)
  • scripts/check-obsolescence-audit.mjs:34 — comment: Reference: ADR 0005 H6 (engineering/decisions/0005-fork-sync-hardening.md)
  • scripts/check-obsolescence-audit.mjs:357 — error message references engineering/notes/provider-model-obsolescence-audit.md

Neither engineering/decisions/ nor engineering/notes/ exists in the remoteclaw repo. Contributors hitting these gates cannot resolve the referenced documents.

Decision (2026-04-20)

ADRs stay in the private HQ repo. remoteclaw CI scripts drop the path references and keep the rule names only.

Rationale:

  • The ADR's audience is fork maintainers (us), not external contributors
  • All 5 existing ADRs (0001-0005) live in HQ and there is no established ADR convention in remoteclaw
  • CI error messages already carry the enforceable rule (ADR 0005 H5, ADR 0005 H6) by name — that is sufficient for enforcement
  • Creating a public ADR convention in remoteclaw just to satisfy stale path comments is overbuilding

This supersedes the original AC of authoring an ADR at the cited path.

Acceptance criteria

  • scripts/check-stub-debt.mjs:13 — strip (engineering/decisions/0005-fork-sync-hardening.md) from the comment; keep ADR 0005 H5 rule name
  • scripts/check-obsolescence-audit.mjs:34 — strip (engineering/decisions/0005-fork-sync-hardening.md) from the comment; keep ADR 0005 H6 rule name
  • scripts/check-obsolescence-audit.mjs:357 — strip , engineering/notes/provider-model-obsolescence-audit.md from the error message output
  • scripts/check-stub-debt.mjs:108 — already correct (rule name only, no path); no change
  • Verify no other path references to engineering/decisions/ or engineering/notes/ remain in the repo
  • CI still passes after the edits

Out of scope

Cascade impact

References

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentation

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions