gut(config): remove dead config schemas for gutted systems (#2302)#2329
Merged
alexey-pelykh merged 1 commit intomainfrom Apr 12, 2026
Merged
gut(config): remove dead config schemas for gutted systems (#2302)#2329alexey-pelykh merged 1 commit intomainfrom
alexey-pelykh merged 1 commit intomainfrom
Conversation
Remove dead Zod schemas, TypeScript types, help text, labels, and legacy migration rules for three gutted subsystems: memory (MemorySchema / MemoryQmd* / MemorySearchSchema), web search/fetch (ToolsWebSearchSchema / ToolsWebFetchSchema / ToolsWebSchema), and Pi orchestrator (embeddedPi). Zod compat stubs (`z.unknown().optional()`) are kept at every config field location so existing user configs with memory/web/embeddedPi sections still parse after upgrade — same pattern used by #2291 before upstream sync #2298 re-introduced the schemas. Scope note: `ToolsConfig.web?` TypeScript shape is intentionally preserved because upstream-synced runtime consumers (`onboard-search.ts`, `configure.wizard.ts`, `audit-extra.sync.ts`, `wizard/onboarding.finalize.ts`) still read `tools.web.search/fetch` fields. The Zod schema is gutted (parsed as `unknown`), and the full removal of those consumers is tracked as follow-up work. Marked with `@deprecated` JSDoc. Tests updated: drop memorySearch assertions from `schema.help.quality.test`, `schema.hints.test`, and the legacy config detection test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead Zod schemas, TypeScript types, help text, labels, and legacy migration rules for three gutted subsystems:
MemorySchema,MemoryQmd*helpers,MemorySearchSchema,MemorySearchConfigtypeToolsWebSearchSchema,ToolsWebFetchSchema,ToolsWebSchemaembeddedPischemaZod compat stubs (
z.unknown().optional()) are kept at every config fieldlocation so existing user configs with
memory.*,memorySearch.*,tools.web.*, orembeddedPi.*sections still parse after upgrade. Samepattern used by #2291 before upstream sync #2298 re-introduced the schemas.
Scope note — follow-up required
ToolsConfig.web?TypeScript shape is intentionally preserved becauseupstream-synced runtime consumers still read
tools.web.search/fetchfields:src/commands/onboard-search.ts(325 LOC)src/commands/onboard-search.test.ts(291 LOC)src/commands/configure.wizard.ts(web search wizard UI)src/security/audit-extra.sync.ts(web secrets audit)src/wizard/onboarding.finalize.ts(web onboarding finalize)The Zod schema is gutted (parsed as
unknown), and the full removal ofthose consumers is out of scope for this gut item — it's a runtime
consumer removal, not a config schema cleanup. Marked with
@deprecatedJSDoc. Follow-up gut item for removing these consumers will be tracked.
Diff
src/config/Test plan
pnpm check(format + typecheck + lint) passesschema.help.quality.test,schema.hints.test,config.legacy-config-detection.accepts-imessage-dmpolicy.testmemory,memorySearch,tools.web,embeddedPistill parse (stubs)Closes #2302
🤖 Generated with Claude Code