Skip to content

gut: remove dead config schemas for gutted systems (MBP audit) #2302

@alexey-pelykh

Description

@alexey-pelykh

Context

Config schemas for gutted systems (memory, web search/fetch, Pi orchestrator) still exist, consuming compile-time complexity. Found during MBP deep dive audit of src/config/.

Scope

Remove dead schemas, types, help text, and labels for:

Memory system (~534 lines):

  • MemorySchema (78 lines in zod-schema.ts)
  • MemorySearchSchema (136 lines in zod-schema.agent-runtime.ts)
  • MemorySearchConfig type (115 lines in types.tools.ts)
  • memorySearch field refs in AgentDefaultsSchema and AgentEntrySchema
  • Memory help text entries (~197 lines in schema.help.ts)
  • Memory label entries (~69 lines in schema.labels.ts)

Web search/fetch (~225 lines):

  • ToolsWebSearchSchema (52 lines) + ToolsWebFetchSchema (12 lines) + parent
  • Web types (82 lines in types.tools.ts)
  • Web help text (~42 lines) and labels (~30 lines)

Pi/plugin remnants (~16 lines):

  • embeddedPi schema (8 lines) + help (4 lines)
  • plugins.slots.memory + plugins.slots.contextEngine (4 lines)

Important: Preserve z.unknown().optional() stubs for any config fields that existing user configs might contain, to avoid breaking config validation on upgrade. This was the approach used by WI-121.

Acceptance Criteria

  • MemorySchema, MemorySearchSchema removed (only stubs remain)
  • ToolsWebSearchSchema, ToolsWebFetchSchema removed (only stubs remain)
  • Corresponding type definitions, help text, and labels removed
  • Config validation still accepts existing configs with memory/web sections (stub compat)
  • Build passes
  • Tests pass

Size

~990 lines removed.

Metadata

Metadata

Assignees

Labels

gutRemoving dead upstream subsystems

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions