feat(remix-dev): add suppport for .mjs and .cjs configs#3675
Merged
kentcdodds merged 4 commits intodevfrom Aug 4, 2022
Merged
Conversation
chaance
approved these changes
Jul 7, 2022
mcansh
approved these changes
Jul 7, 2022
Member
|
Something weird going on with the tests? |
Member
|
Looks like we maybe should include a test or two for this and fix the tests that are broken in this PR |
.mjs and .cjs configs.mjs and .cjs configs
Member
I think supporting |
🦋 Changeset detectedLatest commit: da2d69d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chaance
approved these changes
Aug 4, 2022
mcansh
pushed a commit
that referenced
this pull request
Aug 11, 2022
4 tasks
TooTallNate
pushed a commit
to vercel/vercel
that referenced
this pull request
Jan 13, 2023
…g" (#8793) Adds support for `remix.config.mjs` and `remix.config.cjs` and also updates the example/fixtures to the latest version of Remix. See: remix-run/remix#3675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
remix.config.jsto be written as ESM or CJS following package.jsontypefield conventions for resolution.I.e:
If package.json
"type": "module".jsloaded as ESM.mjsloaded as ESM.cjsloaded as CJSIf package.json is not
"type": "module".jsloaded as CJS.mjsloaded as ESM.cjsloaded as CJSCloses: #
Testing Strategy:
Existing functionality covered by existing tests.