Skip to content

fix(package): upgrade html-dom-parser to fix client ES Module export#663

Merged
remarkablemark merged 1 commit intomasterfrom
fix/html-dom-parser
Aug 20, 2022
Merged

fix(package): upgrade html-dom-parser to fix client ES Module export#663
remarkablemark merged 1 commit intomasterfrom
fix/html-dom-parser

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

What is the motivation for this pull request?

fix(package): upgrade html-dom-parser to fix client ES Module export

See remarkablemark/html-dom-parser#335

What is the current behavior?

ReferenceError: module is not defined

What is the new behavior?

No ReferenceError

Checklist:

@remarkablemark remarkablemark added bug Something isn't working dependencies Pull requests that update a dependency file labels Aug 20, 2022
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 10.23 KB (+0.23% 🔺) 205 ms (+0.23% 🔺) 74 ms (+12.93% 🔺) 279 ms

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 20, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b79658d) to head (415cb59).
⚠️ Report is 1626 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          167       167           
  Branches        57        57           
=========================================
  Hits           167       167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remarkablemark remarkablemark merged commit 42fe77e into master Aug 20, 2022
@remarkablemark remarkablemark deleted the fix/html-dom-parser branch August 20, 2022 02:53
@remarkablemark
Copy link
Copy Markdown
Owner Author

Release #664 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants