Skip to content

Fix boolean attributes parsing#50

Merged
remarkablemark merged 1 commit intoremarkablemark:masterfrom
yuliya-ivaniukovich:bool-props-fix
Mar 27, 2018
Merged

Fix boolean attributes parsing#50
remarkablemark merged 1 commit intoremarkablemark:masterfrom
yuliya-ivaniukovich:bool-props-fix

Conversation

@yuliya-ivaniukovich
Copy link
Copy Markdown
Contributor

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 11, 2018

Coverage Status

Coverage increased (+0.03%) to 99.206% when pulling e478a44 on yuliya-ivaniukovich:bool-props-fix into 29084cf on remarkablemark:master.

Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR @yuliya-ivaniukovich

Everything looks great but do you mind amending your commit message because the format is used for the version bump and changelog update:

fix(parser): fix boolean attributes parsing

@remarkablemark remarkablemark self-assigned this Mar 14, 2018
@remarkablemark remarkablemark added the bug Something isn't working label Mar 14, 2018
@yuliya-ivaniukovich
Copy link
Copy Markdown
Contributor Author

Amended message as requested.

@remarkablemark remarkablemark merged commit c344883 into remarkablemark:master Mar 27, 2018
d-lazarev pushed a commit to d-lazarev/html-react-parser that referenced this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants