Refactor HTML to DOM modules and environment detection logic#5
Merged
remarkablemark merged 1 commit intomasterfrom Aug 24, 2016
Merged
Refactor HTML to DOM modules and environment detection logic#5remarkablemark merged 1 commit intomasterfrom
remarkablemark merged 1 commit intomasterfrom
Conversation
Move the client/server environment detection logic to the entry file. Rename `lib/html-to-dom.js` to `lib/html-to-dom-server.js` and move the client-side parsing logic to `lib/html-to-dom-client.js`. `lib/html-to-dom-server.js` will only contain the server-side logic. Fix and update the tests.
a9333b5 to
cfeaea5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor HTML to DOM modules (server and client). The environment detection logic (browser versus node) now resides in the entry module
index.js. This allows the client-side versus server-side parsing logic to stay within their respective modules.Tasks:
lib/html-to-dom.jstolib/html-to-dom-server.jsand move the client-side parsing logic tolib/html-to-dom-client.js.lib/html-to-dom-server.jswill only contain the server-side logic.