fix(package): add domhandler to dependencies#240
Merged
remarkablemark merged 1 commit intoremarkablemark:masterfrom Apr 12, 2021
Merged
fix(package): add domhandler to dependencies#240remarkablemark merged 1 commit intoremarkablemark:masterfrom
remarkablemark merged 1 commit intoremarkablemark:masterfrom
Conversation
remarkablemark
requested changes
Apr 12, 2021
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
Could you amend your commit message so it's more descriptive?
git commit --amend -m 'fix(package): add domhandler to dependencies' -m 'Fixes #240'
git push -f
package.json
Outdated
| "dom" | ||
| ], | ||
| "dependencies": { | ||
| "domhandler": "^4.0.0", |
Owner
There was a problem hiding this comment.
Do you mind making this an exact dependency? 4.0.0
remarkablemark
approved these changes
Apr 12, 2021
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
LGTM, thanks for opening this PR @kfritsch
Owner
|
@kfritsch I'll make a release later tonight |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added missing dependency for "domhandler": "^4.0.0"
fixes #231
Checklist:
Explanation can be found in the issue. Only tested the workaround explained in the issue.