Fix parsing of <script> and <style> tags#20
Merged
remarkablemark merged 1 commit intomasterfrom Aug 30, 2016
Merged
Conversation
- Ensure empty <script> tag is converted to a React element and not an empty array `[]` - Add missing logic for parsing <style> DOM nodes to React element - Update tests and mocks
remarkablemark
added a commit
that referenced
this pull request
Aug 30, 2016
- Fix parsing of <script> and <style> tags (#20) - Remove `key` parameter in `replace` method and use `React.cloneElement` instead - Update tests and mocks - Update README and remove `key` parameter in `replace` - Update ESLint rule for `no-unused-vars`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
Tasks:
<script>tag is converted to a React element and not an empty array[]<style>DOM nodes to React element