build(rollup): replace rollup plugin uglify with terser#179
Merged
remarkablemark merged 1 commit intomasterfrom Nov 1, 2020
Merged
build(rollup): replace rollup plugin uglify with terser#179remarkablemark merged 1 commit intomasterfrom
remarkablemark merged 1 commit intomasterfrom
Conversation
Fix error when installing with npm 7: ```sh $ npm install npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! Found: rollup@2.32.1 npm ERR! node_modules/rollup npm ERR! dev rollup@"^2.12.1" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer rollup@">=0.66.0 <2" from rollup-plugin-uglify@6.0.4 npm ERR! node_modules/rollup-plugin-uglify npm ERR! dev rollup-plugin-uglify@"^6.0.4" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Fix Travis CI build error when installing with npm 7:
To resolve peerDependencies error and support rollup v2, replace rollup-plugin-uglify with rollup-plugin-terser.
See TrySound/rollup-plugin-uglify#82