List React 17 as peer dependency#178
Merged
remarkablemark merged 1 commit intoremarkablemark:masterfrom Nov 3, 2020
Merged
Conversation
remarkablemark
requested changes
Nov 1, 2020
Owner
There was a problem hiding this comment.
Thanks for opening this PR @DreierF! Do you mind amending the commit message so it follows the Conventional Commits format?
git commit --amend "build(package): add react v17 to peerDependencies"
git push -fThis is crucial because the commit message is used to generate the release and changelog.
Owner
|
You may also want to rebase with latest git remote add upstream https://github.com/remarkablemark/html-react-parser.git
git fetch upstream
git rebase upstream/masterSee syncing a fork for more details. |
Contributor
Author
|
Sure. Done :) |
remarkablemark
approved these changes
Nov 3, 2020
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
The library currently does not list React 17 as peer dependency