fix(index): add default export for parser#144
Merged
remarkablemark merged 3 commits intoremarkablemark:masterfrom Mar 13, 2020
heldergoncalves92:master
Merged
fix(index): add default export for parser#144remarkablemark merged 3 commits intoremarkablemark:masterfrom heldergoncalves92:master
remarkablemark merged 3 commits intoremarkablemark:masterfrom
heldergoncalves92:master
Conversation
remarkablemark
requested changes
Mar 12, 2020
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
Thanks for the opening the PR!
Do you mind amending your commit so the build passes?
git commit --amend -m "fix(index): add default export for parser"
git push -fAlso, do you mind adding a test?
Contributor
Author
I can add it! 👍 |
Owner
|
Also minor note, the last commit message could be: We use conventional commits to release, so it follows the Angular commit message guidelines. |
remarkablemark
approved these changes
Mar 13, 2020
Owner
remarkablemark
left a comment
There was a problem hiding this comment.
LGTM, thanks for opening this PR and making these changes @heldergoncalves92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143