Skip to content

fix(index): add default export for parser#144

Merged
remarkablemark merged 3 commits intoremarkablemark:masterfrom
heldergoncalves92:master
Mar 13, 2020
Merged

fix(index): add default export for parser#144
remarkablemark merged 3 commits intoremarkablemark:masterfrom
heldergoncalves92:master

Conversation

@heldergoncalves92
Copy link
Copy Markdown
Contributor

@heldergoncalves92 heldergoncalves92 commented Mar 12, 2020

Fixes #143

@remarkablemark remarkablemark self-requested a review March 12, 2020 19:39
Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the opening the PR!

Do you mind amending your commit so the build passes?

git commit --amend -m "fix(index): add default export for parser"
git push -f

Also, do you mind adding a test?

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 13, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 064f0df on heldergoncalves92:master into 039e1c1 on remarkablemark:master.

@heldergoncalves92
Copy link
Copy Markdown
Contributor Author

Thanks for the opening the PR!

Do you mind amending your commit so the build passes?

git commit --amend -m "fix(index): add default export for parser"
git push -f

Also, do you mind adding a test?

I can add it! 👍

@remarkablemark remarkablemark added the bug Something isn't working label Mar 13, 2020
@remarkablemark
Copy link
Copy Markdown
Owner

Also minor note, the last commit message could be:

test(html-to-react): add test to ensure default export for parser

We use conventional commits to release, so it follows the Angular commit message guidelines.

Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for opening this PR and making these changes @heldergoncalves92

@remarkablemark remarkablemark changed the title Update index.js fix(index): add default export for parser Mar 13, 2020
@remarkablemark remarkablemark merged commit 4f10d6d into remarkablemark:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Index.d.ts does not match with Index.js

3 participants