feat: replace react-dom-core with react-property#117
Merged
remarkablemark merged 7 commits intomasterfrom Jul 9, 2019
Merged
Conversation
Save `react-property@0.1.0` to package.json dependencies and remove `react-dom-core`. Delete `lib/property-config.js` given that the mapping is already created in `react-property`. Fix incorrect test since both `ychannelselector` and `yChannelSelector` are applicable SVG attribute names. Resolves #107
For HTML DOM attributes that can be either boolean or string, make sure to convert the value correctly for React. Add test to confirm `download` attribute is properly converted.
Since the property config is a POJO (Plain Old JavaScript Object), this means the Object properties/methods are accessible. Thus, use `hasOwnProperty` to check if the attribute name is on the config map rather than on the Object prototype chain. Handle attributes that share the same name as custom attributes.
Owner
Author
|
Owner
Author
|
There are optimizations that help decrease the final bundle size.
Owner
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #107