Skip to content

feat: replace react-dom-core with react-property#117

Merged
remarkablemark merged 7 commits intomasterfrom
feat/react-property
Jul 9, 2019
Merged

feat: replace react-dom-core with react-property#117
remarkablemark merged 7 commits intomasterfrom
feat/react-property

Conversation

@remarkablemark
Copy link
Copy Markdown
Owner

@remarkablemark remarkablemark commented Jul 8, 2019

Resolves #107

Save `react-property@0.1.0` to package.json dependencies and remove
`react-dom-core`.

Delete `lib/property-config.js` given that the mapping is already
created in `react-property`.

Fix incorrect test since both `ychannelselector` and
`yChannelSelector` are applicable SVG attribute names.

Resolves #107
For HTML DOM attributes that can be either boolean or string,
make sure to convert the value correctly for React.

Add test to confirm `download` attribute is properly converted.
Since the property config is a POJO (Plain Old JavaScript Object),
this means the Object properties/methods are accessible.

Thus, use `hasOwnProperty` to check if the attribute name is on the
config map rather than on the Object prototype chain.

Handle attributes that share the same name as custom attributes.
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 8, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 26ebef9 on feat/react-property into c963bc0 on master.

@remarkablemark
Copy link
Copy Markdown
Owner Author

File react-dom-core react-property
html-react-parser.js 66K 69K
html-react-parser.min.js 19K 25K

@remarkablemark
Copy link
Copy Markdown
Owner Author

File react-dom-core react-property@0.1.0 react-property@1.0.0
html-react-parser.js 66K 69K 54K
html-react-parser.min.js 19K 25K 18K

There are optimizations that help decrease the final bundle size.
@remarkablemark
Copy link
Copy Markdown
Owner Author

File react-dom-core react-property@0.1.0 react-property@1.0.0 react-property@1.0.1
html-react-parser.js 66K 69K 54K 53K
html-react-parser.min.js 19K 25K 18K 17K

@remarkablemark remarkablemark merged commit 6278ec1 into master Jul 9, 2019
@remarkablemark remarkablemark deleted the feat/react-property branch July 9, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drop dependency on react 15

2 participants