refactor(domToReact): refactoring multiple types#1133
Merged
remarkablemark merged 1 commit intoremarkablemark:masterfrom Oct 30, 2023
Merged
refactor(domToReact): refactoring multiple types#1133remarkablemark merged 1 commit intoremarkablemark:masterfrom
remarkablemark merged 1 commit intoremarkablemark:masterfrom
Conversation
Release-As: 5.0.2
Codecov Report
@@ Coverage Diff @@
## master #1133 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 153 152 -1
Branches 50 50
=========================================
- Hits 153 152 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ssi02014
commented
Oct 30, 2023
Contributor
Author
ssi02014
left a comment
There was a problem hiding this comment.
@remarkablemark 👋
I'm so happy that html-react-parser now supports Typescript. I worked on some small improvements.
I've left my intention in the comments. Please review it when you have a moment. Thank you. 😊
remarkablemark
approved these changes
Oct 30, 2023
Owner
Contributor
Author
|
@remarkablemark Thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-As: 5.0.2
What is the motivation for this pull request?
Stricter management of constants and improved types.
What is the current behavior?
There is no change in behavior.
What is the new behavior?
There is no change in behavior.
Checklist: