-
-
Notifications
You must be signed in to change notification settings - Fork 140
Comparing changes
Open a pull request
base repository: remarkablemark/html-react-parser
base: v0.8.1
head repository: remarkablemark/html-react-parser
compare: v0.9.0
- 9 commits
- 5 files changed
- 2 contributors
Commits on Jul 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0ae8a11 - Browse repository at this point
Copy the full SHA 0ae8a11View commit details -
feat(attributes-to-props): replace
react-domwithreact-propertySave `react-property@0.1.0` to package.json dependencies and remove `react-dom-core`. Delete `lib/property-config.js` given that the mapping is already created in `react-property`. Fix incorrect test since both `ychannelselector` and `yChannelSelector` are applicable SVG attribute names. Resolves #107
Configuration menu - View commit details
-
Copy full SHA for d6274b9 - Browse repository at this point
Copy the full SHA d6274b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17fbdfd - Browse repository at this point
Copy the full SHA 17fbdfdView commit details -
feat(attributes-to-props): check for overloaded boolean values
For HTML DOM attributes that can be either boolean or string, make sure to convert the value correctly for React. Add test to confirm `download` attribute is properly converted.
Configuration menu - View commit details
-
Copy full SHA for 1151cfb - Browse repository at this point
Copy the full SHA 1151cfbView commit details -
fix(attributes-to-props): handle attr named after Object properties
Since the property config is a POJO (Plain Old JavaScript Object), this means the Object properties/methods are accessible. Thus, use `hasOwnProperty` to check if the attribute name is on the config map rather than on the Object prototype chain. Handle attributes that share the same name as custom attributes.
Configuration menu - View commit details
-
Copy full SHA for 3f857bb - Browse repository at this point
Copy the full SHA 3f857bbView commit details
Commits on Jul 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 25828d5 - Browse repository at this point
Copy the full SHA 25828d5View commit details -
build(package): update
react-propertyto 1.0.1There are optimizations that help decrease the final bundle size.
Configuration menu - View commit details
-
Copy full SHA for 26ebef9 - Browse repository at this point
Copy the full SHA 26ebef9View commit details -
Merge pull request #117 from remarkablemark/feat/react-property
feat: replace `react-dom-core` with `react-property`
Configuration menu - View commit details
-
Copy full SHA for 6278ec1 - Browse repository at this point
Copy the full SHA 6278ec1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 474c8cd - Browse repository at this point
Copy the full SHA 474c8cdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.8.1...v0.9.0