Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.8.1
Choose a base ref
...
head repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.0
Choose a head ref
  • 9 commits
  • 5 files changed
  • 2 contributors

Commits on Jul 7, 2019

  1. Configuration menu
    Copy the full SHA
    0ae8a11 View commit details
    Browse the repository at this point in the history
  2. feat(attributes-to-props): replace react-dom with react-property

    Save `react-property@0.1.0` to package.json dependencies and remove
    `react-dom-core`.
    
    Delete `lib/property-config.js` given that the mapping is already
    created in `react-property`.
    
    Fix incorrect test since both `ychannelselector` and
    `yChannelSelector` are applicable SVG attribute names.
    
    Resolves #107
    remarkablemark committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    d6274b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    17fbdfd View commit details
    Browse the repository at this point in the history
  4. feat(attributes-to-props): check for overloaded boolean values

    For HTML DOM attributes that can be either boolean or string,
    make sure to convert the value correctly for React.
    
    Add test to confirm `download` attribute is properly converted.
    remarkablemark committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    1151cfb View commit details
    Browse the repository at this point in the history
  5. fix(attributes-to-props): handle attr named after Object properties

    Since the property config is a POJO (Plain Old JavaScript Object),
    this means the Object properties/methods are accessible.
    
    Thus, use `hasOwnProperty` to check if the attribute name is on the
    config map rather than on the Object prototype chain.
    
    Handle attributes that share the same name as custom attributes.
    remarkablemark committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    3f857bb View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Configuration menu
    Copy the full SHA
    25828d5 View commit details
    Browse the repository at this point in the history
  2. build(package): update react-property to 1.0.1

    There are optimizations that help decrease the final bundle size.
    remarkablemark committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    26ebef9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #117 from remarkablemark/feat/react-property

    feat: replace `react-dom-core` with `react-property`
    remarkablemark authored Jul 9, 2019
    Configuration menu
    Copy the full SHA
    6278ec1 View commit details
    Browse the repository at this point in the history
  4. chore(release): 0.9.0

    remarkablemark committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    474c8cd View commit details
    Browse the repository at this point in the history
Loading