Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.0
Choose a base ref
...
head repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.1
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Nov 17, 2016

  1. Fix bug since DOMPropertyConfigs are moved to react-dom in v15.4 

    Both `HTMLDOMPropertyConfig.js` and `SVGDOMPropertyConfig.js` used
to be in `react/lib/` directory but since v15.4.x, the configs
have been moved to `react-dom/lib/`.

Created a module that tried to require either `react-dom/lib/`
or `react/lib/` (fallback).

A more permanent (less error-prone) solution may be to keep a
hardcopy of both configs in the repository (minimize coupling and
risk of another change from breaking the package).

Fixes #29
    @remarkablemark
    remarkablemark committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    3537bbd View commit details
    Browse the repository at this point in the history

  2. Merge pull request #30 from remarkablemark/bug-react 

    Fix bug due to DOMPropertyConfigs being moved to `react-dom` in v15.4
    @remarkablemark
    remarkablemark authored Nov 17, 2016
    Configuration menu
    Copy the full SHA
    d99cf97 View commit details
    Browse the repository at this point in the history

  3. Bump version to 0.1.1 

    Fix require logic as HTMLDOMPropertyConfig and SVGDOMPropertyConfig
are moved from `react/lib/` to `react/lib/` in v15.4 (#29)
    @remarkablemark
    remarkablemark committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    b809226 View commit details
    Browse the repository at this point in the history
Loading