Fix bug due to DOMPropertyConfigs being moved to react-dom in v15.4#30
Merged
remarkablemark merged 1 commit intomasterfrom Nov 17, 2016
Merged
Fix bug due to DOMPropertyConfigs being moved to react-dom in v15.4#30remarkablemark merged 1 commit intomasterfrom
react-dom in v15.4#30remarkablemark merged 1 commit intomasterfrom
Conversation
Both `HTMLDOMPropertyConfig.js` and `SVGDOMPropertyConfig.js` used to be in `react/lib/` directory but since v15.4.x, the configs have been moved to `react-dom/lib/`. Created a module that tried to require either `react-dom/lib/` or `react/lib/` (fallback). A more permanent (less error-prone) solution may be to keep a hardcopy of both configs in the repository (minimize coupling and risk of another change from breaking the package). Fixes #29
react-dom in v15.4react-dom in v15.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
HTMLDOMPropertyConfig.jsandSVGDOMPropertyConfig.jsused to be inreact/lib/directory but since v15.4.x, the configs have been moved toreact-dom/lib/.Created a module that tried to require either
react-dom/lib/orreact/lib/(fallback).Todo:
A more permanent (less error-prone) solution may be to keep a hardcopy of both configs in the repository (minimize coupling and risk of another change from breaking the package).
Update travis to test react and react-dom versions
15.3and15.4.Fixes #29