Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.4
Choose a base ref
...
head repository: remarkablemark/html-react-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.5
Choose a head ref
  • 7 commits
  • 7 files changed
  • 2 contributors

Commits on Aug 30, 2016

  1. Remove key parameter from replace and use React.cloneElement 

    The previous implementation was to pass the `key` as the 2nd
parameter in `replace` method and force the user to set the
"key" prop in their custom React element.

This creates further complexity for the end-user.

As a result, use `React.cloneElement` which does the same thing
without additional work from the user.

`React.cloneElement` takes the React element and merges the
"key" prop taken from the array index with the original
element's props when applicable.

https://facebook.github.io/react/docs/top-level-api.html#react.cloneelement
    @remarkablemark
    remarkablemark committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    b86a350 View commit details
    Browse the repository at this point in the history

  2. Update README with the key parameter in replace removed

    @remarkablemark
    remarkablemark committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    e18cf81 View commit details
    Browse the repository at this point in the history

  3. Update ESLint rule for no-unused-vars 

    Check all variables for usage but do not check function arguments.
    @remarkablemark
    remarkablemark committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    26e4e7c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #18 from remarkablemark/remove-replace-key 

    Remove `key` parameter from `replace` and use `React.cloneElement` instead
    @remarkablemark
    remarkablemark authored Aug 30, 2016
    Configuration menu
    Copy the full SHA
    7522a0a View commit details
    Browse the repository at this point in the history

  5. Fix parsing of <script> and <style> tags 

    - Ensure empty <script> tag is converted to a React element and
  not an empty array `[]`
- Add missing logic for parsing <style> DOM nodes to React element
- Update tests and mocks
    @remarkablemark
    remarkablemark committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    9170e92 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #20 from remarkablemark/bug-script-style 

    Fix parsing of <script> and <style> tags
    @remarkablemark
    remarkablemark authored Aug 30, 2016
    Configuration menu
    Copy the full SHA
    020973e View commit details
    Browse the repository at this point in the history

  7. Bump version to 0.0.5 

    - Fix parsing of <script> and <style> tags (#20)
- Remove `key` parameter in `replace` method and use
  `React.cloneElement` instead
- Update tests and mocks
- Update README and remove `key` parameter in `replace`
- Update ESLint rule for `no-unused-vars`
    @remarkablemark
    remarkablemark committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    11770d9 View commit details
    Browse the repository at this point in the history
Loading