Remove key parameter from replace and use React.cloneElement instead#18
Merged
remarkablemark merged 3 commits intomasterfrom Aug 30, 2016
Merged
Remove key parameter from replace and use React.cloneElement instead#18remarkablemark merged 3 commits intomasterfrom
key parameter from replace and use React.cloneElement instead#18remarkablemark merged 3 commits intomasterfrom
Conversation
The previous implementation was to pass the `key` as the 2nd parameter in `replace` method and force the user to set the "key" prop in their custom React element. This creates further complexity for the end-user. As a result, use `React.cloneElement` which does the same thing without additional work from the user. `React.cloneElement` takes the React element and merges the "key" prop taken from the array index with the original element's props when applicable. https://facebook.github.io/react/docs/top-level-api.html#react.cloneelement
Check all variables for usage but do not check function arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #16
Issue:
The previous fix to mitigate the React unique keys warning was to pass the
keyas the 2nd parameter in thereplacemethod.However, this burdens users with the extra work and responsibility to set the "key" prop on their custom React element.
Enhancement:
The smarter approach done in this pull request was to use React.cloneElement to clone the user's custom React element and merge the key prop for them (when applicable).
Tasks:
keyparameter inreplacemethod inREADME.md.eslintrc